fix(types): avoid adding non-existent properties from model constructor for typegoose #11986

vkarpov15 · 2022-06-24T20:53:21Z

Fix #11960

Summary

In #11563, it looks like the model constructor pulls types from the parameter to the model constructor, which is very wrong. @hasezoey reported that this also causes issues for Typegoose.

The tests in document.test.ts#L195-L196 are also wrong, unExistProperty shouldn't be defined on the document instance. See the below script:

const mongoose = require('mongoose');

void async function main() {
  await mongoose.connect('mongodb://localhost:27017');

  const Test = mongoose.model('Test', mongoose.Schema({ name: String }));
  const doc = new Test({ name: 'test', unExistProperty: 1 });
  console.log(doc);
  console.log(doc.name); // 'test'
  console.log(doc.unExistProperty); // undefined

  await mongoose.disconnect();
}();

Examples

…or for typegoose Fix #11960

mohammad0-0ahmad · 2022-06-25T00:24:23Z

Hello @vkarpov15!
The changes look good to cover the regression.
Because of the requirements, you described "arbitrary objects in new and create and insert". I did these changes.
Anyway, I would like to say this changes make it better, and I would prefer as will to prevent adding "arbitrary objects" when strict mode is enabled.
I will consider making that available, "If you think that correct"
Thanks for fixing this regression @vkarpov15, and sorry for the trouble @hasezoey, and thanks for reporting the issue.
Best Regards!

vkarpov15 added 2 commits June 24, 2022 16:44

fix(types): avoid adding non-existent properties from model construct…

5409717

…or for typegoose Fix #11960

test: add test case for #11960

5753bce

vkarpov15 requested a review from Uzlopak June 24, 2022 20:53

vkarpov15 self-assigned this Jun 24, 2022

vkarpov15 merged commit 4f89f23 into master Jun 25, 2022

vkarpov15 deleted the vkarpov15/gh-11960 branch June 25, 2022 01:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(types): avoid adding non-existent properties from model constructor for typegoose #11986

fix(types): avoid adding non-existent properties from model constructor for typegoose #11986

vkarpov15 commented Jun 24, 2022

mohammad0-0ahmad commented Jun 25, 2022 •

edited

Loading

fix(types): avoid adding non-existent properties from model constructor for typegoose #11986

fix(types): avoid adding non-existent properties from model constructor for typegoose #11986

Conversation

vkarpov15 commented Jun 24, 2022

mohammad0-0ahmad commented Jun 25, 2022 • edited Loading

mohammad0-0ahmad commented Jun 25, 2022 •

edited

Loading